-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select: Overflow ellipsis and control over multi value wrapping #76405
Conversation
(Open the links below in a new tab to go to the correct steps)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good in general, just wonder if the whole truncate behavior should be configurable via a prop? I assume there could be instances where the users of the component would not want to truncate the values for their own reasons and considering that this is the most widely used component we have, the number of such cases could be non-trivial.
@Clarity-89 The truncation only kicks in when the new option "noMultiValueWrap" is true. The non-multi-value select already truncates long values that do not fit, we have no option for that there so why have it for MultiSelect? I think this is a safe new behavior that should not change any current multi-selects (As they will continue to wrap and hence show no truncation ) |
We are using Select & MultiSelect for variable value selection in scenes (so in app plugins and new core dashboards).
grafana/scenes#399
Done
Before:
A long value:
Many values that cause wrapping
After:
Single long value and noMultiValueWrap=true
maxVisibleItems = 4 and noMultiValueWrap=true
Unrelated fixes