Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PublicDashboards: Enable feature by default for GA and remove public preview text #76484

Merged
merged 4 commits into from Oct 13, 2023

Conversation

juanicabanas
Copy link
Contributor

@juanicabanas juanicabanas commented Oct 12, 2023

What is this feature?

It updates the feature flag to be enabled by default.

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #74350
#74693

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@juanicabanas juanicabanas changed the title PublicDashboards: Enable feature by default for GA PublicDashboards: Enable feature by default for GA and remove public preview text Oct 12, 2023
@imatwawana
Copy link
Collaborator

imatwawana commented Oct 12, 2023

@juanicabanas - There's a note indicating public dashboards is in public preview at the top of this page:
https://grafana.com/docs/grafana/latest/dashboards/dashboard-public/

@juanicabanas
Copy link
Contributor Author

@juanicabanas - There's a note indicating public dashboards is in public preview at the top of this page: https://grafana.com/docs/grafana/latest/dashboards/dashboard-public/

Should we remove the whole note or change it to GA?

@imatwawana
Copy link
Collaborator

@juanicabanas - There's a note indicating public dashboards is in public preview at the top of this page: https://grafana.com/docs/grafana/latest/dashboards/dashboard-public/

Should we remove the whole note or change it to GA?

Just remove it

@juanicabanas juanicabanas requested review from a team and imatwawana as code owners October 12, 2023 21:07
@juanicabanas juanicabanas requested review from polibb and removed request for a team October 12, 2023 21:07
@AgnesToulet AgnesToulet merged commit 40b79de into main Oct 13, 2023
19 checks passed
@AgnesToulet AgnesToulet deleted the juanicabanas/public_dashboards_default_enablement branch October 13, 2023 14:32
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
darrenjaneczek pushed a commit that referenced this pull request Oct 23, 2023
…preview text (#76484)

* public dashboard for GA

* files modified

* public preview removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Enable public dashboards by default on prem
5 participants