Loki: Fix Autocomplete in stream selector overwriting existing label names, or inserting autocomplete result within label value #76485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the word pattern to include label value separator (=), include valid sting chars (-), and value wrapper ("), adding some more logic in the range calculation to prevent autocomplete results from partially overwriting adjacent label names or portions of the current label value
…ls' into gtk-grafana/logs/issues/75925/auto-complete-fixes
…ls' into gtk-grafana/logs/issues/75925/auto-complete-fixes
…es/75925/auto-complete-fixes
…es/75925/auto-complete-fixes
…es/75925/auto-complete-fixes
gtk-grafana
added
area/query-editor
add to changelog
no-backport
|
Backend code coverage report for PR #76485 |
|
Frontend code coverage report for PR #76485
|
|
It looks like it requires quotes to trigger the value autocompletes. Would it be possible to trigger it after the equal? Quotes.mov |
|
Fantastic, thanks! |
gtk-grafana
merged commit c4187d2
into
gtk-grafana/logs/issues/75820/autocomplete-between-labels
28 of 29 checks passed
gtk-grafana
deleted the
gtk-grafana/logs/issues/75925/auto-complete-fixes
branch
gtk-grafana
added a commit
that referenced
this pull request
Oct 13, 2023
…ore or between other labels (#75925) * Fix issue getting current labels that would only grab values to the left of the cursor * Loki: Fix Autocomplete in stream selector overwriting existing label names, or inserting autocomplete result within label value (#76485) * Better autocomplete functionality in loki, changing the word pattern to include label value separator (=), include valid sting chars (-), and value wrapper ("), adding some more logic in the range calculation to prevent autocomplete results from partially overwriting adjacent label names or portions of the current label value
darrenjaneczek
pushed a commit
that referenced
this pull request
Oct 23, 2023
…ore or between other labels (#75925) * Fix issue getting current labels that would only grab values to the left of the cursor * Loki: Fix Autocomplete in stream selector overwriting existing label names, or inserting autocomplete result within label value (#76485) * Better autocomplete functionality in loki, changing the word pattern to include label value separator (=), include valid sting chars (-), and value wrapper ("), adding some more logic in the range calculation to prevent autocomplete results from partially overwriting adjacent label names or portions of the current label value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
PoC:
Changing the wordPattern monaco uses to identify words which we used to calculate the monaco range.
This allows us to somewhat dynamically calculate range passed into monaco to prevent overwriting adjacent label names, or portions of label values surrounding the users cursor.
Why do we need this feature?
Makes writing queries easier, fixes code UX papercuts.
Who is this feature for?
Loki users
Which issue(s) does this PR fix?:
Fixes #75820
Special notes for your reviewer:
Child PR of #75925
Created this PR after I accidentally pinged every reviewer (by merging main into this branch instead of the parent)
#76080
Please check that: