-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Fix empty folder details for nested folder items #76504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
/deploy-to-hg |
|
|
/deploy-to-hg |
|
This comment was marked as resolved.
This comment was marked as resolved.
/deploy-to-hg |
|
|
/deploy-to-hg |
|
This comment was marked as resolved.
This comment was marked as resolved.
zserge
previously approved these changes
Oct 18, 2023
Moving a folder/dashboard to root didn't update the folder_uid column to become null.
/deploy-to-hg |
|
|
/deploy-to-hg |
|
|
zserge
approved these changes
Oct 23, 2023
This was referenced Nov 1, 2023
papagian
added
add to changelog
and removed
no-changelog
Skip including change in changelog/release notes
labels
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/backend/db/migration
area/backend
area/frontend
no-backport
Skip backport of PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
For nested folders we have to refer to the
folder
table for getting the parent folder details instead of thedashboard
tablethat knows only of flat folders. However, in the search query we used to join with the latter on
folder_id
column. As a result parent folder details were missing for a subfolder.The sequential IDs for a folder differ in
folder
anddashboard
table: but theirUID
s are the same.This fix:
folder_uid
column indashboard
tablefolder_uid
into the existing dashboard and folder rows in thedashboard
table. (this can take several minutes for large setups > 1M dashboards)folder_uid
when saving a dashboard or folderWhy do we need this feature?
This is introduced for fixing search results for the nested folders feature but we need it in general because in the future we want to exclusively use the
folder
table for storing folders and without this migration this is not possible.Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #74433
Special notes for your reviewer:
To reproduce the issue:
main
api/search?query=New
responseapi/search?query=child
responseTry also moving a subfolder under another folder and to the root and make sure that search response is correct.
Please check that: