Alerting: Separate overlapping legacy and UA alerting routes #76517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobsonMT
added
area/alerting
JacobsonMT
requested review from
joshhunt,
eledobleefe,
gillesdemey,
VikaCep,
konrad147,
soniaAguilarPeiron,
papagian,
zserge and
mildwonkey
and removed request for
a team
|
/deploy-to-hg |
|
JacobsonMT
changed the title
konrad147
reviewed
Oct 13, 2023
|
Good question, only notification channels have deep links that would change with this PR, alert rules would link to the dashboard (which doesn't change in this PR). I wouldn't expect us to embed a deep link to the channel, but I'll fish around. Of course, if they manually add a link in the notification message it will break as well. |
JacobsonMT
force-pushed
the
jacobsonmt/separate_legacy_UA_routes
branch
from
67535a6
to
0d3889c
Compare
|
/deploy-to-hg |
|
|
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 2 weeks. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
api/alert-notifiers, alerting/list, and alerting/notifications existed in both legacy and UA. Rename legacy route paths and nav ids to be independent of UA ones.
JacobsonMT
force-pushed
the
jacobsonmt/separate_legacy_UA_routes
branch
from
11f503f
to
e31c7e9
Compare
|
/deploy-to-hg |
|
|
JacobsonMT
added
area/alerting/migration
zserge
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Separate overlapping legacy and UA alerting routes api/alert-notifiers, alerting/list, and alerting/notifications existed in both legacy and UA. Rename legacy route paths and nav ids to be independent of UA ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate upcoming feature flag and migration/upgrade page improvements, it's necessary to separate the shared legacy alerting and unified alerting routes / api endpoints.
This renames the legacy routes/api's and keeps the UA ones the same, this should limit impact of unintentional problems. Changes:
api/alert-notifiers->api/alert-notifiers-legacyalerting/list->alering-legacy/listalerting/notificationsand various subpaths such as/alerting/notifications/receivers/:id/edit->alerting-legacy/...Special notes for your reviewer:
I don't think we reference the legacy routes and apis in the docs anymore, but if you know of a spot I can update it.
Extracted from: #76074
Please check that: