Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas: Promote Button to beta #76582

Merged
merged 4 commits into from Oct 13, 2023
Merged

Canvas: Promote Button to beta #76582

merged 4 commits into from Oct 13, 2023

Conversation

adela-almasan
Copy link
Contributor

This PR

  • promotes the Canvas Button to beta state
  • removes check for disableSanitizeHtml feature flag
  • removes the disable check for button - good to have in the future, but maybe in a better form

Fixes #76498

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@adela-almasan adela-almasan added area/frontend add to changelog area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR labels Oct 13, 2023
@adela-almasan adela-almasan added this to the 10.2.x milestone Oct 13, 2023
@adela-almasan adela-almasan self-assigned this Oct 13, 2023
@adela-almasan adela-almasan requested a review from a team as a code owner October 13, 2023 20:51
@adela-almasan adela-almasan requested review from Develer and drew08t and removed request for a team October 13, 2023 20:51
Copy link
Contributor

@drew08t drew08t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adela-almasan adela-almasan enabled auto-merge (squash) October 13, 2023 21:41
@adela-almasan adela-almasan merged commit 3ba78c4 into main Oct 13, 2023
16 checks passed
@adela-almasan adela-almasan deleted the canvas_button_beta branch October 13, 2023 22:59
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
darrenjaneczek pushed a commit that referenced this pull request Oct 23, 2023
@nordby
Copy link

nordby commented Oct 31, 2023

WHT! net::ERR_CERT_AUTHORITY_INVALID Urgently add the --unsecured flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canvas: Button promote to beta and remove need for ff to enable functionality
4 participants