Snapshots: Fix breakage of some panel types due to missing structureRev #76586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
requested review from
axelavargas and
polibb
and removed request for
a team
leeoniya
commented
Oct 13, 2023
| @@ -104,6 +104,7 @@ export class PanelQueryRunner { | |||
| state: LoadingState.Done, | |||
| series: this.dataConfigSource.snapshotData.map((v) => toDataFrame(v)), | |||
| timeRange: getDefaultTimeRange(), // Don't need real time range for snapshots | |||
| structureRev, | |||
There was a problem hiding this comment.
this is just a drive-by improvement
leeoniya
commented
Oct 13, 2023
| @@ -36,6 +36,7 @@ export function loadSnapshotData(panel: PanelModel, dashboard: DashboardModel): | |||
| theme: config.theme2, | |||
| timeZone: dashboard.getTimezone(), | |||
| }), | |||
| structureRev: 1, | |||
There was a problem hiding this comment.
actual fix. should be fine to hard-code a static value cause snapshots are static, iiuc.
adela-almasan
approved these changes
Oct 13, 2023
leeoniya
changed the title
darrenjaneczek
pushed a commit
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the panel rendering concerns in #64262
Fixes https://github.com/grafana/support-escalations/issues/7580
we rely on
structureRevto re-configure and re-init panel options when the dataframe shape or the config struct changes. in snapshot loading this was alwaysundefinedand we did not re-init. snapshots re-render the panel 3 times (the first time with empty data), as opposed to the PanelQueryRunner, where it just renders once with data.