-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Add Alerting menu in getPanelMenu #76618
Alerting: Add Alerting menu in getPanelMenu #76618
Conversation
/deploy-to-hg |
|
f65674f
to
30451b6
Compare
|
dc3b979
to
2f8c051
Compare
6e8e7a8
to
0e3ba6b
Compare
…in DashobardPicker panels
0e3ba6b
to
39fc333
Compare
…warning in DashobardPicker panels" This reverts commit 225da3f.
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
…r and rename it to getCreateAlertInMenuAvailability
This would have been a perfect use case for UI extensions. We could have added it by adding a configuration for the panel menu item extension. See example on how explore does it. The benefits of doing it this way is that you get a clean contract between the dashboard and alert domain. The extending part (Alerting in this case) can decide when the extension should be visible by registering a configuration function. Please see this documentation for more information: https://grafana.com/developers/plugin-tools/ui-extensions/ |
Thank you, @mckn, for your suggestion. We aim to enable users to create alerts from any panel, allowing them to reuse queries. |
What is this feature?
When it comes to exploration, creating an alert rule from a panel can be quite challenging to find and use.
This PR adds the capability to
create an alert from a dashboard Panel
, allowing it to be done from the...More
subMenu.The logic to render or not this menu will be having unified alerting enabled in config and the right permissions to update alerts.
It will be possible to create an alert from any panel type. BUT we only allow creating an alert from any type of panel. So , users can re-use a panel query for creating an alert.
Panel Behavior Remains Unchanged:
It's important to note that this change does not alter the behavior of the panels themselves. Panels continue to operate in their usual way, and this feature merely extends the alerting capabilities, making it easier for users to set up alerts directly from their dashboard.
This feature will provide greater flexibility to users. It allows the creation of alerts from any type of panel, enabling users to leverage existing panel queries to set up alerting.
Why do we need this feature?
Users need to easily create an alert from any panel.
Who is this feature for?
All users.
Which issue(s) does this PR fix?:
Fixes https://github.com/grafana/alerting-squad/issues/638
Special notes for your reviewer:
alert-from.-panel-7.mp4
Please check that: