Tracing: Trace to profiles #76670
Merged
Tracing: Trace to profiles #76670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe in backend based on spanSelector presence
joey-grafana
added
add to changelog
area/datasource/frontend
area/tracing
datasource/Tempo
no-backport
aocenas
reviewed
Oct 17, 2023
public/app/core/components/TraceToProfiles/TraceToProfilesSettings.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/grafana-pyroscope-datasource/QueryEditor/QueryOptions.tsx
Show resolved
Hide resolved
public/app/plugins/datasource/grafana-pyroscope-datasource/dataquery.cue
Show resolved
Hide resolved
joey-grafana
commented
Oct 19, 2023
aocenas
reviewed
Oct 24, 2023
public/app/core/components/TraceToProfiles/TraceToProfilesSettings.tsx
Outdated
Show resolved
Hide resolved
|
Trying this with the pyro test docker compose but I don't see any link. 
Is it possible the |
|
@aocenas yeah this was updated in the time since I created the PR. Updated that now so all good for review. |
aocenas
approved these changes
Oct 31, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Trace to profiles support.
Why do we need this feature?
Allows users to easily link from their tracing to their profiling data source.
Who is this feature for?
Tracing/profiling users.
Special notes for your reviewer:
You can test with the Pyroscope docker-compose.
Need to enable the feature toggle
traceToProfiles.Please check that: