Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Add status_source label to plugin request logs #76676

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Plugins: Add status_source label to plugin request logs #76676

merged 1 commit into from
Oct 17, 2023

Conversation

xnyo
Copy link
Member

@xnyo xnyo commented Oct 17, 2023

What is this feature?

Adds status_source label to plugin request logs if its feature flag PluginsInstrumentationStatusSource is enabled.

Why do we need this feature?

More info in #75761

Who is this feature for?

Grafana Labs.

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@xnyo xnyo added this to the 10.2.x milestone Oct 17, 2023
@xnyo xnyo self-assigned this Oct 17, 2023
@xnyo xnyo requested a review from a team as a code owner October 17, 2023 08:54
@xnyo xnyo requested review from wbrowne, marefr and andresmgot and removed request for a team October 17, 2023 08:54
marefr
marefr approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great

@xnyo xnyo merged commit c4fefd8 into main Oct 17, 2023
26 checks passed
@xnyo xnyo deleted the giuseppe/error-source-logs branch October 17, 2023 09:09
@marefr marefr mentioned this pull request Oct 18, 2023
Open
@zerok zerok modified the milestones: 10.2.x, 10.3.x Oct 20, 2023
darrenjaneczek pushed a commit that referenced this pull request Oct 23, 2023
@xnyo @darrenjaneczek
Plugins: Add status_source label to plugin request logs (#76676)
57705b9
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marefr marefr marefr approved these changes

@wbrowne wbrowne Awaiting requested review from wbrowne wbrowne is a code owner automatically assigned from grafana/plugins-platform-backend

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees

@xnyo xnyo

Labels
add to changelog area/backend/plugins area/backend area/plugins go Pull requests that update Go code no-backport Skip backport of PR
Projects
Plugins Platform
Archived in project
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xnyo @marefr @zerok @aangelisc