Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudwatch: Add missing appsync metrics #76703

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Cloudwatch: Add missing appsync metrics #76703

merged 1 commit into from
Nov 29, 2023

Conversation

ctobolski
Copy link
Contributor

What is this feature?

Updates Cloudwatch Metrics for Appsync

Why do we need this feature?

To support more metrics!

Who is this feature for?

Cloudwatch users

Which issue(s) does this PR fix?:

Fixes #76701

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ctobolski ctobolski requested a review from a team as a code owner October 17, 2023 15:55
@ctobolski ctobolski requested review from idastambuk and kevinwcyu and removed request for a team October 17, 2023 15:55
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label Nov 17, 2023
@fridgepoet
Copy link
Member

Hey @ctobolski 😎 Wanna finish something today? (jk)
Do you still want to work on this one? Can you sign the CLA?

@fridgepoet fridgepoet added no-backport Skip backport of PR add to changelog and removed stale Issue with no recent activity labels Nov 17, 2023
@ctobolski
Copy link
Contributor Author

Whoopsie daisy! I updated the CLA

@sarahzinger sarahzinger added this to the 10.3.x milestone Nov 29, 2023
@sarahzinger sarahzinger changed the title Cloudwatch: add missing appsync metrics Cloudwatch: Add missing appsync metrics Nov 29, 2023
sarahzinger
sarahzinger approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉

@sarahzinger sarahzinger merged commit 5c451cb into grafana:main Nov 29, 2023
24 checks passed
@sarahzinger sarahzinger mentioned this pull request Nov 29, 2023
Open
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

@idastambuk idastambuk Awaiting requested review from idastambuk idastambuk is a code owner automatically assigned from grafana/aws-datasources

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
add to changelog area/backend datasource/CloudWatch no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
None yet
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

Cloudwatch: Update AppSync metrics
5 participants
@ctobolski @CLAassistant @fridgepoet @sarahzinger @aangelisc