-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canvas: Add Pan and Zoom #76705
Canvas: Add Pan and Zoom #76705
Conversation
This reverts commit 3d1dd65.
About to do some refactoring. I will make sure to test this afterwards! |
…ng calculated correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇 great job on this! I went through and smoothed a few things over - I'm comfortable with this in its current state to move forward and merge :)
Re: @Develer finding with phantom context menu while in panel edit mode, I was also able to replicate that. I created #79883 as a follow-up to address that bug / edge case (at this point I don't think we should block merging this PR as this is an experimental feature behind a FF and we need to prioritize progress over perfection 😬)
></div> | ||
<TransformComponent>{sceneDiv}</TransformComponent> | ||
</TransformWrapper> | ||
<SceneTransformWrapper scene={this}>{sceneDiv}</SceneTransformWrapper> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Hi Thanks in advance |
Thanks for the feedback, @kasaranenikarthik! Please create an issue so we can better capture and track what you are experiencing. |
Hi, I am trying to overlay elements in exact locations over a large jpeg, set as background in Original scaling mode. I also want it to be responsive and work on desktop and iphone, i.e. portrait and landscape. The issue I have with canvasPanelPanZoom on a narrow iphone browser (or a narrowed desktop browser) is that the background image is only initially rendered as wide as the browser window allows, trimming off the right hand side of the jpeg image as expected, but you can never zoom or pan to the right hand side of the image / canvas panel and see the "trimmed" bit, if that makes sense? Likewise in the vertical plane, if the panel height is not high enough to contain the original background image, then you will never be able to zoom or pan down to the bottom part of the background image. Thanks p.s. would you like me to create this as an Issue? thanks |
Add pan and zoom to canvas.
This feature will exist behind feature flag: canvasPanelPanZoom
:(:)Mini map is only updating for arrowsTo be addressed later: Canvas: Include preview of canvas in minimap #78561New "Simplified" Minimap:
![Nov-22-2023 14-42-00](https://private-user-images.githubusercontent.com/60050885/285059862-fcfdc69d-79b5-4bb4-b0b2-d7d228655ea4.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxODg1NjcsIm5iZiI6MTcyMjE4ODI2NywicGF0aCI6Ii82MDA1MDg4NS8yODUwNTk4NjItZmNmZGM2OWQtNzliNS00YmI0LWIwYjItZDdkMjI4NjU1ZWE0LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE3Mzc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNlOGFjNzNjMWFmNTA4ZDQyYzFkM2RkODMwOTdjY2FjOTA2N2Y0OGM3NzljYzJmODk2NDU3NGUxODk5YmFjYzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.jLmNa1fY0Q6sw2I0CNQdvMDh3mGzHXjoscPftipWhWg)
Pan / Zoom:
![Oct-24-2023 10-38-50](https://private-user-images.githubusercontent.com/60050885/277756810-40c5ab88-ae63-4082-b761-6502c2b286c8.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxODg1NjcsIm5iZiI6MTcyMjE4ODI2NywicGF0aCI6Ii82MDA1MDg4NS8yNzc3NTY4MTAtNDBjNWFiODgtYWU2My00MDgyLWI3NjEtNjUwMmMyYjI4NmM4LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE3Mzc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJjYWNkOTQ4MmFmZWNmNTZiYmZhM2NiZTA3NTU4YThhOWZlOGRmOGRmOThlYTRkMDJlNjdhM2U2MDhiMTVmOWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.PrAQWOyUBts7_H1bMae4zVc52IsXqJT0g7qeGebrtDw)
![Nov-06-2023 18-15-43](https://private-user-images.githubusercontent.com/60050885/280899531-3909340e-44bd-4d9d-b444-6af22bb8f645.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxODg1NjcsIm5iZiI6MTcyMjE4ODI2NywicGF0aCI6Ii82MDA1MDg4NS8yODA4OTk1MzEtMzkwOTM0MGUtNDRiZC00ZDlkLWI0NDQtNmFmMjJiYjhmNjQ1LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE3Mzc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVmOGQ0MGY0YjRhYWY5ZDU4OTc1YmM3Zjk4YjI1MjQ4MDBlODFjN2VlNGQ3YTM5ZGU1ZmZjYmEzOTI4NGVjYjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ZF1Dm4s5pgXWZXpgz5oStkju_FS_LS90owJALdDCwoY)
![Nov-06-2023 18-15-54](https://private-user-images.githubusercontent.com/60050885/280899522-88660828-248a-4093-bd29-316d0aaa9f94.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxODg1NjcsIm5iZiI6MTcyMjE4ODI2NywicGF0aCI6Ii82MDA1MDg4NS8yODA4OTk1MjItODg2NjA4MjgtMjQ4YS00MDkzLWJkMjktMzE2ZDBhYWE5Zjk0LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE3Mzc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQzMzUyOGYwZjM3YTUyMmM0ZGU2MWJmNTMwYzZiZWE2NjFjNzQxYmFmOGY5ZTI5NTkzYjBiNTA3YWI5ZDI2NjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.IikrPizggoEC88XuFe25vugZub5u8EJthjMC_duIJ1w)
![Nov-06-2023 18-16-28](https://private-user-images.githubusercontent.com/60050885/280899507-a2369c78-63a5-4dfd-a7ab-7b49684868b7.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxODg1NjcsIm5iZiI6MTcyMjE4ODI2NywicGF0aCI6Ii82MDA1MDg4NS8yODA4OTk1MDctYTIzNjljNzgtNjNhNS00ZGZkLWE3YWItN2I0OTY4NDg2OGI3LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE3Mzc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI4OWJmZThmZDNlMWRmNzg1YjM5YWUzMzU5ODQ0MWVkMjNhNTVhYjU1YTdmYTQxNDFlMTRhYjU1YTQwZDIxYTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.VK707H7qjXSMfqp7HQAoManjHzvPUwtF3WHV7zo4mgk)
![Nov-06-2023 18-15-10](https://private-user-images.githubusercontent.com/60050885/280899551-e99b9f06-a45e-4be7-a863-4ab657407f23.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxODg1NjcsIm5iZiI6MTcyMjE4ODI2NywicGF0aCI6Ii82MDA1MDg4NS8yODA4OTk1NTEtZTk5YjlmMDYtYTQ1ZS00YmU3LWE4NjMtNGFiNjU3NDA3ZjIzLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE3Mzc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA2MjU0MzE3MTg4OTUyNjUxZTU5ZDE1NWRmNDliNDMxMzgwMjQ0ZDI3ZGVlMjg1OTMwMzBmNzhlZmFiODg4NzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.DkjqG1hFvEjTEuD8yKSRnE_gvvVZhzQq59oAC5KK-1A)
Arrow Behavior:
Add Element During Zoom:
Resize/Delete Arrow:
Select:
Closes #63902, #73953, #73177