Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Pass OTEL sampling config to plugins #76834

Merged
merged 11 commits into from
Nov 10, 2023
Merged

Plugins: Pass OTEL sampling config to plugins #76834

merged 11 commits into from
Nov 10, 2023

Conversation

xnyo
Copy link
Member

@xnyo xnyo commented Oct 19, 2023 •
edited
Loading

What is this feature?

Passes OTEL sampling config values to plugins via env vars.

This is requires for grafana/grafana-plugin-sdk-go#781 to work.

Why do we need this feature?

Fixes grafana/grafana-plugin-sdk-go#734

Who is this feature for?

Plugin developers and Grafana operators.

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@xnyo xnyo added this to the 10.3.x milestone Oct 19, 2023
@xnyo xnyo self-assigned this Oct 19, 2023
@xnyo xnyo mentioned this pull request Oct 19, 2023
Merged
@xnyo xnyo changed the title WIP: Plugins: Pass OTEL sampling config to plugins Plugins: Pass OTEL sampling config to plugins Nov 8, 2023
@xnyo xnyo marked this pull request as ready for review November 8, 2023 10:29
@xnyo xnyo requested review from a team as code owners November 8, 2023 10:29
@xnyo xnyo requested review from wbrowne, marefr, andresmgot, mildwonkey, undef1nd, nikimanoledaki and oshirohugo and removed request for a team November 8, 2023 10:29
wbrowne
wbrowne approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think!

pkg/plugins/envvars/envvars.go Outdated Show resolved Hide resolved
@xnyo xnyo requested a review from wbrowne November 9, 2023 08:55
marefr
marefr approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great

wbrowne
wbrowne approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🚀

@xnyo xnyo merged commit 7b4bcc8 into main Nov 10, 2023
14 checks passed
@xnyo xnyo deleted the giuseppe/tracing-sampling branch November 10, 2023 13:56
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbrowne wbrowne wbrowne approved these changes

@marefr marefr marefr approved these changes

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-backend

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

@undef1nd undef1nd Awaiting requested review from undef1nd undef1nd was automatically assigned from grafana/backend-platform

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki nikimanoledaki was automatically assigned from grafana/backend-platform

@oshirohugo oshirohugo Awaiting requested review from oshirohugo

Assignees

@xnyo xnyo

Labels
add to changelog area/backend/plugins area/backend area/plugins area/tracing go Pull requests that update Go code no-backport Skip backport of PR
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

Tracing: Support remote, rate-limited, and probabilistic sampling
4 participants
@xnyo @wbrowne @marefr @aangelisc