InfluxDB: Fix table parsing with backend mode #76899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmylife
added
type/bug
datasource/InfluxDB
no-changelog
itsmylife
commented
Oct 20, 2023
Comment on lines
+258
to
+261
| if resultFormat != "table" { | ||
| frameName = append(frameName, row.Name...) | ||
| frameName = append(frameName, '.') | ||
| } |
There was a problem hiding this comment.
We remove those in table responses for frontend mode compatibility
itsmylife
added
add to changelog
breaking change
13 tasks
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
* Add resultFormat to query model * don't add row name if the result format is table * No need special formatting since we use unified dataframes * betterer * specify visualization type in response * Unit tests * fix unit tests (cherry picked from commit 63abe25)
itsmylife
added a commit
that referenced
this pull request
Oct 23, 2023
InfluxDB: Fix table parsing with backend mode (#76899) * Add resultFormat to query model * don't add row name if the result format is table * No need special formatting since we use unified dataframes * betterer * specify visualization type in response * Unit tests * fix unit tests (cherry picked from commit 63abe25) Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR is addressing a couple of issues altogether.
select qqq, eee from somewherewe return the names assomewhere.qqq and somewhere.eee. This is not compatible with what we have with the frontend mode.join by field) is failing since backend is sending field names with rowsWho is this feature for?
InfluxDB influxql users with backend mode enabled.
Which issue(s) does this PR fix?:
Fixes #76897
Special notes for your reviewer:
How to test
influxdbBackendMigration=falseSELECT usage_idle, usage_iowait FROM "cpu" WHERE $timeFilterusage_idleandusage_iowaitTime,usage_idle,usage_iowaitcolumns backinfluxdbBackendMigration=trueRelease notice breaking change
For the existing backend mode users who have table visualization might see some inconsistencies on their panels. We have updated the table column naming. This will potentially affect field transformations and/or field overrides. To resolve this either: