Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.2.x] Alerting: Alert rule constraint violations return as 400s in provisioning API #76978

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 39599fa from #76396


What is this feature?

Fixes the status code on constraint violation errors.

We use database constraints to enforce things like rule name uniqueness. This will make the API return the correct status code when a user tries to create/modify rule to where it breaches this.

Which issue(s) does this PR fix?:
n/a

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

…ning API (#76396)

Constraint violations become 400s

(cherry picked from commit 39599fa)
@alexweav alexweav merged commit 048797f into v10.2.x Oct 23, 2023
23 checks passed
@alexweav alexweav deleted the backport-76396-to-v10.2.x branch October 23, 2023 17:25
@aangelisc aangelisc modified the milestones: 10.2.x, 10.2.1 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants