Alerting: Dont show 1 firing series when no data in Expressions PreviewSummary #76981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaAguilarPeiron
added
type/bug
area/alerting
soniaAguilarPeiron
requested review from
gillesdemey,
VikaCep and
konrad147
and removed request for
a team
VikaCep
reviewed
Oct 23, 2023
public/app/features/alerting/unified/components/expressions/Expression.tsx
Outdated
Show resolved
Hide resolved
VikaCep
approved these changes
Oct 23, 2023
…ing-in-expression-summary-when-no-data
konrad147
reviewed
Oct 24, 2023
| @@ -238,6 +232,21 @@ export const PreviewSummary: FC<{ firing: number; normal: number; isCondition: b | |||
| return <span className={mutedText}>{`${seriesCount} series`}</span>; | |||
| }; | |||
|
|
|||
| export function getGroupedByStateAndSeriesCount(series: DataFrame[]) { | |||
konrad147
reviewed
Oct 24, 2023
| @@ -82,3 +82,74 @@ function makeSeries(n: number) { | |||
| }) | |||
| ); | |||
| } | |||
|
|
|||
| describe('getGroupedByStateAndSeriesCount', () => { | |||
soniaAguilarPeiron
deleted the
alerting/not-show-firing-in-expression-summary-when-no-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR fixes the issue related to Expressions incorrectly counting fired alerts when no data is present.
Why do we need this feature?
We need to show consistent and accurate counts in the PreviewSummary on the Alert rule form.
Who is this feature for?
All users.
Which issue(s) does this PR fix?:
Fixes https://github.com/grafana/support-escalations/issues/7811
Special notes for your reviewer:
After the change:
Please check that: