Plugins: Allow disabling angular deprecation UI for specific plugins

[xnyo]

What is this feature?

Adds hideAngularDeprecation to frontendsettings for each plugin. This field is set by the backend if the config contains hide_angular_deprecation = true in the plugin's settings:

[plugin.grafana-worldmap-panel]
hide_angular_deprecation = true

When this is true, the angular deprecation UI elements for that particular plugin will be hidden from dashboards. This does not affect other code relying on Angular detection (e.g.: plugins sandboxing), but it only hides the following UI elements from dashboards:

• Warning at the top of the dashboard (if FF is enabled)
• Icons on affected panels (if FF is enabled)
• Warnings when editing a panel

Why do we need this feature?

Rework of #71067 without breaking changes, as detect-angular-dashboards now depends on it. Due to it the previous PR got stale and was never merged.

Who is this feature for?

Grafana users relying on Angular plugins.

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

• It works as expected from a user's perspective.
• If this is a pre-GA feature, it is behind a feature toggle.
• The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

[mckn]

Overall I think this looks good! I have added a suggestion about grouping the properties together in a struct and also revisit the types on the frontend since I believe we have added the properties incorrectly to the plugin meta type.

[mckn]

Would it make sense to group these into an angular struct? Something like: type Angular struct { Detected: bool HideDeprecation: bool }?

[xnyo]

Yes, it makes sense. I tried avoiding it so we don't introduce a breaking change. However this piece of information is currently being used only by the sandbox and detect-angular-dashboards, as far as I know. Since we own both pieces, and it was suggested also in the original PR, I will do it the way you suggested 😄

[github-actions]

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-data has possible breaking changes (more info)
grafana-runtime has possible breaking changes (more info)

Console output
Read our guideline

[mckn]

LGTM!

I got the functionality working for the akumuli-datasource but I couldn't get it to work for the graph.

This was the config I used:

[plugin.graph]
hide_angular_deprecation = true

[xnyo]

I got the functionality working for the akumuli-datasource but I couldn't get it to work for the graph.

This was the config I used:

[plugin.graph]
hide_angular_deprecation = true

Good catch! I have fixed the issue here: 7880738. However, angular.detected will still be false because angular detections do not work properly for core plugins as we inspect the plugin's module.js file.

graph still gets flagged as angular by the frontend because we check for angularPanelCtrl as well:

grafana/public/app/features/dashboard/state/PanelModel.ts

Line 620 in a36e0fe

return (this.plugin && this.plugin.angularPanelCtrl) !== undefined || (this.plugin?.meta?.angular?.detected ?? false);

However angular.detected being false can have some unintended side effects, I will take a look but it's not related/introduced to this PR :)