Alerting: Allow more time before Alertmanager expire-resolves alerts #77094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
added
type/bug
area/alerting
alexweav
requested review from
a team,
rwwiv,
JacobsonMT,
yuri-tceretian and
grobinson-grafana
and removed request for
a team
yuri-tceretian
approved these changes
Oct 24, 2023
grobinson-grafana
approved these changes
Oct 24, 2023
alexweav
force-pushed
the
alexweav/increase-endsAt-factor
branch
from
58e4e56
to
c0348ba
Compare
alexweav
added
no-backport
ssama88
pushed a commit
to ssama88/grafana
that referenced
this pull request
Oct 31, 2023
…rafana#77094) * Sync endsAt factor with prometheus * Fix state tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
We saw an issue recently where long queries (thereby dropped ruler ticks) were causing flapping, due to the alert timing out in alertmanager and getting force-resolved.
Prometheus itself ran into the same issue intermittently prometheus/prometheus#5277
Though, through a different vector; there, alerts were failing to make it to the alertmanager.
Still, this change allows more "slack" in the event of ruler delays, and synchronizes us back with Prometheus. The original choice of
3seems to be prometheus inspired, let's follow the trend there.Which issue(s) does this PR fix?:
n/a
Special notes for your reviewer:
Please check that: