Alerting: Show receiver in groups view to avoid duplication in the list #77109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaAguilarPeiron
added
area/alerting
soniaAguilarPeiron
requested review from
gillesdemey,
VikaCep and
konrad147
and removed request for
a team
|
Can we use the same styles as the notification policies for the "delivered to"? |
Done! @gillesdemey |
gillesdemey
reviewed
Oct 25, 2023
public/app/features/alerting/unified/components/alert-groups/AlertGroup.tsx
Outdated
Show resolved
Hide resolved
soniaAguilarPeiron
force-pushed
the
alerting/Fix-duplication-in-groups-view
branch
from
bd9b55a
to
eb92d40
Compare
soniaAguilarPeiron
force-pushed
the
alerting/Fix-duplication-in-groups-view
branch
from
eb92d40
to
d774b7f
Compare
gillesdemey
reviewed
Oct 25, 2023
public/app/features/alerting/unified/components/alert-groups/AlertGroup.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
In the Groups page, sometimes groups appear to be duplicated. This may lead to confusion.
The reason behind this issue is that alert groups are grouped based on the receivers they are associated with.
However, this receiver information is not displayed in the list, which can result in a misunderstanding of these groups.
This pull request addresses this issue by including the receiver name for each group when no additional grouping has been selected.
Why do we need this feature?
Alert group page show display an accurate list.
Who is this feature for?
All users.
Which issue(s) does this PR fix?:
Fixes https://github.com/grafana/support-escalations/issues/8022
Special notes for your reviewer:
When no additional grouping selected
When additional grouping is selected
Please check that: