Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfluxDB: Fix adhoc filter calls by properly checking optional parameter in metricFindQuery #77113

Merged
merged 2 commits into from
Oct 25, 2023
Merged

InfluxDB: Fix adhoc filter calls by properly checking optional parameter in metricFindQuery #77113

merged 2 commits into from
Oct 25, 2023

Conversation

itsmylife
Copy link
Contributor

What is this feature?

Check the optional options parameter in metricFindQuery method.

Who is this feature for?

InfluxDB frontend mode users

Which issue(s) does this PR fix?:

Fixes #77105

Special notes for your reviewer:

How to test?

  • run grafana with influxdbBackendMigration=false
  • set up and influxdb dashboard
  • add a new ad-hoc filter and save the dashboard
  • go to the dashboard and try to see the ad-hoc filter keys, it will be failed to load
  • switch to this branch and try again

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@itsmylife itsmylife added type/bug add to changelog no-changelog Skip including change in changelog/release notes backport v10.2.x labels Oct 25, 2023
@itsmylife itsmylife requested a review from a team as a code owner October 25, 2023 07:51
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.3.x milestone Oct 25, 2023
This was referenced Oct 25, 2023
Closed
Open
@itsmylife itsmylife merged commit 283f279 into main Oct 25, 2023
30 checks passed
@itsmylife itsmylife deleted the ismail/optional-parameter-check-in-metricFindQuery branch October 25, 2023 13:56
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Oct 25, 2023
Merged
3 tasks
grafana-delivery-bot bot pushed a commit that referenced this pull request Oct 25, 2023
@itsmylife @grafana-delivery-bot
InfluxDB: Fix adhoc filter calls by properly checking optional parame…
6b039c1 
…ter in metricFindQuery (#77113)

* Handle optional options parameter

* unit tests

(cherry picked from commit 283f279)
itsmylife added a commit that referenced this pull request Oct 25, 2023
@grafana-delivery-bot @itsmylife
[v10.2.x] InfluxDB: Fix adhoc filter calls by properly checking optio…
3b4be7d 
…nal parameter in metricFindQuery (#77145)

InfluxDB: Fix adhoc filter calls by properly checking optional parameter in metricFindQuery (#77113)

* Handle optional options parameter

* unit tests

(cherry picked from commit 283f279)

Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
ssama88 pushed a commit to ssama88/grafana that referenced this pull request Oct 31, 2023
@itsmylife @ssama88
InfluxDB: Fix adhoc filter calls by properly checking optional parame…
cb5f8b8 
…ter in metricFindQuery (grafana#77113)

* Handle optional options parameter

* unit tests
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bohandley bohandley bohandley approved these changes

Assignees
No one assigned
Labels
add to changelog area/frontend backport v10.2.x datasource/InfluxDB no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

upgrade from version 10.1.5 to version 10.2.0, influxql adhoc filters gives me "failed to load options"
3 participants
@itsmylife @bohandley @aangelisc