Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Replace crewjam/saml with the latest grafana/saml lib #77153

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Chore: Replace crewjam/saml with the latest grafana/saml lib #77153

merged 1 commit into from
Oct 26, 2023
+8 −12

Conversation

mgyongyosi
Copy link
Contributor

What is this feature?

Replace crewjam/saml with the latest grafana/saml lib which contains every change from the upstream (crewjam/saml)

Why do we need this feature?

Who is this feature for?

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@mgyongyosi mgyongyosi added area/auth add to changelog backport v8.4.x Mark PR for automatic backport to v8.4.x area/auth/saml backport v9.4.x Mark PR for automatic backport to v9.4.x backport v9.5.x Bot will automatically open backport PR backport v10.0.x backport v10.1.x backport v10.2.x labels Oct 25, 2023
@mgyongyosi mgyongyosi added this to the 10.3.x milestone Oct 25, 2023
@mgyongyosi mgyongyosi requested a review from a team as a code owner October 25, 2023 15:40
@mgyongyosi mgyongyosi requested review from papagian, zserge and mildwonkey and removed request for a team October 25, 2023 15:40
@grafana-delivery-bot
Copy link
Contributor

Hello @mgyongyosi!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

2 similar comments
@grafana-delivery-bot
Copy link
Contributor

Hello @mgyongyosi!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@grafana-delivery-bot
Copy link
Contributor

Hello @mgyongyosi!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@grafana-delivery-bot
Copy link
Contributor

Hello @mgyongyosi!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

2 similar comments
@grafana-delivery-bot
Copy link
Contributor

Hello @mgyongyosi!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@grafana-delivery-bot
Copy link
Contributor

Hello @mgyongyosi!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@mgyongyosi mgyongyosi added no-backport Skip backport of PR and removed backport v8.4.x Mark PR for automatic backport to v8.4.x backport v9.4.x Mark PR for automatic backport to v9.4.x backport v9.5.x Bot will automatically open backport PR backport v10.0.x backport v10.1.x backport v10.2.x labels Oct 26, 2023
@mgyongyosi mgyongyosi merged commit 75768ce into main Oct 26, 2023
42 checks passed
@mgyongyosi mgyongyosi deleted the mgyongyosi/update-saml-lib branch October 26, 2023 07:44
ssama88 pushed a commit to ssama88/grafana that referenced this pull request Oct 31, 2023
@mgyongyosi @ssama88
Chore: Replace crewjam/saml with the latest grafana/saml lib (grafana…
e9d6596 
…#77153)

Replace crewjam/saml with the latest grafana/saml
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mildwonkey mildwonkey mildwonkey approved these changes

@IevaVasiljeva IevaVasiljeva IevaVasiljeva approved these changes

@kalleep kalleep kalleep approved these changes

@alexanderzobnin alexanderzobnin Awaiting requested review from alexanderzobnin

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

Assignees
No one assigned
Labels
add to changelog area/auth/saml area/auth area/backend missing-labels no-backport Skip backport of PR
Projects
None yet
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mgyongyosi @mildwonkey @IevaVasiljeva @kalleep @aangelisc