Loki: Add optional stream selector to fetchLabelValues API #77207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
requested review from
trevorwhitney and
svennergr
and removed request for
a team
ivanahuckova
added
datasource/Loki
area/plugins/app
|
Backend code coverage report for PR #77207 |
|
Frontend code coverage report for PR #77207
|
svennergr
approved these changes
Oct 26, 2023
public/app/plugins/datasource/loki/docs/app_plugin_developer_documentation.md
Show resolved
Hide resolved
…ocumentation.md Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
10 tasks
ssama88
pushed a commit
to ssama88/grafana
that referenced
this pull request
Oct 31, 2023
…7207) * Loki: Add optional stream selector to fetchLabelValues API * Update public/app/plugins/datasource/loki/docs/app_plugin_developer_documentation.md Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com> * Update tests --------- Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are adding optional options to
fetchLabelValueswith possibility to specifystreamSelector. The API for fetching label values includes options to addquerywhich is basicallystreamSelector(I decided to name parameterstreamSelectorcausequeryis vague and we can't include things like parsers or other operations) https://grafana.com/docs/loki/latest/reference/api/#list-label-values-within-a-range-of-timeThe reason why we are creating
optionsrather than just passingstreamSelectoras second parameter is because in the future we could expand this to other things, such as specifying customtimeRangeor something else.This was requested by @trevorwhitney to help them develop app plugin.