Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: Remove dummy trim dashboard api #77249

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Oct 26, 2023

What is this feature?

This removes the /api/dashboards/trim endpoint -- it currently does not do anything, and does not have a clear path todo anything interesting anytime soon.

This was marked as FeatureStagePublicPreview -- but I think we can just remove it since it never did anything 🤷🏻

Why do we need this feature?

We should reduce the number of unused/unsupported feature toggles.

Who is this feature for?

all grafana developers

@ryantxu ryantxu requested review from grafanabot and a team as code owners October 26, 2023 21:29
@ryantxu ryantxu requested review from dprokop, kaydelaney, ashharrison90, eledobleefe, nikimanoledaki, suntala and yangkb09 and removed request for a team October 26, 2023 21:29
@ryantxu ryantxu added add to changelog no-backport Skip backport of PR labels Oct 26, 2023
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.3.x milestone Oct 26, 2023
@ryantxu ryantxu requested review from a team, evictorero and lucychen-grafana and removed request for a team October 26, 2023 21:29
@ryantxu
Copy link
Member Author

ryantxu commented Oct 27, 2023

@papagian / @nikimanoledaki -- any hints on how to update the openapi docs? With an up-to-date enterprise checkout, when I run:

make swagger-clean && make openapi3-gen

There are a LOT of changes that seem unrelated to the this change, mostly looks like:
image

are there more tools/versions or something that may be off?

@nikimanoledaki
Copy link
Contributor

Hi @ryantxu, a couple of things could cause this:

  • Is the branch synced with main?
  • Is your local Grafana repo linked with Enterprise but the local Enterprise repo is outdated?

Could you check if either of the above produce the expected changes?

We would also appreciate any feedback for how to improve the UX for developers around this check :)

@ryantxu
Copy link
Member Author

ryantxu commented Oct 27, 2023

thanks @nikimanoledaki -- branch is up-to-date with main, enterprise is on main and dev.sh was run:
image
image

Then following the directions from the failure:
image
...
image
image

image

and the final result:
image

maybe something cached somewhere? maybe different versions of tools?

@grafana-pr-automation grafana-pr-automation bot added type/ci Tasks related to Continuous Integration workflow datasource/Prometheus labels Nov 2, 2023
@nikimanoledaki nikimanoledaki force-pushed the remove-dummy-trim-command branch 2 times, most recently from 371cdac to 77a83b0 Compare November 2, 2023 12:41
@nikimanoledaki nikimanoledaki removed the type/ci Tasks related to Continuous Integration workflow label Nov 2, 2023
@ryantxu ryantxu merged commit 45d59cf into main Nov 2, 2023
19 checks passed
@ryantxu ryantxu deleted the remove-dummy-trim-command branch November 2, 2023 15:35
zserge pushed a commit that referenced this pull request Nov 9, 2023
Co-authored-by: nikimanoledaki <niki.manoledaki@grafana.com>
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants