-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboards: Remove dummy trim dashboard api #77249
Conversation
@papagian / @nikimanoledaki -- any hints on how to update the openapi docs? With an up-to-date enterprise checkout, when I run:
There are a LOT of changes that seem unrelated to the this change, mostly looks like: are there more tools/versions or something that may be off? |
Hi @ryantxu, a couple of things could cause this:
Could you check if either of the above produce the expected changes? We would also appreciate any feedback for how to improve the UX for developers around this check :) |
thanks @nikimanoledaki -- branch is up-to-date with main, enterprise is on main and Then following the directions from the failure: ![]() maybe something cached somewhere? maybe different versions of tools? |
371cdac
to
77a83b0
Compare
77a83b0
to
92fa8b9
Compare
Co-authored-by: nikimanoledaki <niki.manoledaki@grafana.com>
What is this feature?
This removes the
/api/dashboards/trim
endpoint -- it currently does not do anything, and does not have a clear path todo anything interesting anytime soon.This was marked as FeatureStagePublicPreview -- but I think we can just remove it since it never did anything 🤷🏻
Why do we need this feature?
We should reduce the number of unused/unsupported feature toggles.
Who is this feature for?
all grafana developers