-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore: Avoid reinitializing graph on every query run #77281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing like a single char PR! Works good for me locally, thanks for finding the fix for this so quickly!
Backend code coverage report for PR #77281 |
Frontend code coverage report for PR #77281
|
(cherry picked from commit bf554d1)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-77281-to-v10.2.x origin/v10.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x bf554d121cc116457f3432f2448314381b234016 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-77281-to-v10.2.x
# Create the PR body template
PR_BODY=$(gh pr view 77281 --json body --template 'Backport bf554d121cc116457f3432f2448314381b234016 from #77281{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[v10.2.x] Explore: Avoid reinitializing graph on every query run" --body-file - --label "type/bug" --label "area/explore" --label "area/frontend" --label "add to changelog" --label "backport" --base v10.2.x --milestone 10.2.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-77281-to-v10.2.x
# Create a pull request where the `base` branch is `v10.2.x` and the `compare`/`head` branch is `backport-77281-to-v10.2.x`.
# Remove the local backport branch
git switch main
git branch -D backport-77281-to-v10.2.x |
What is this feature?
Fixes the structureRev logic in explore so that the first result is not 0, which would cause the graph to re-init at every render.
Why do we need this feature?
1 - improves performance as no initialization is done if not needed
2 - having it to 0 would cause the graph to re-init at every render, due to some timing issues with changing queries and zooming, thous would break explore. see #77237 for details
Who is this feature for?
Explore users
Which issue(s) does this PR fix?:
Fixes #77237
Special notes for your reviewer:
Please check that: