Explore: Fix panes vertical scrollbar not being draggable #77284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harisrozajac
approved these changes
Oct 27, 2023
3 tasks
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
Explore: Fix panes verticall scrollbar not being draggable (cherry picked from commit dae49fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Fixes vertical scrollbars i explore panes not being draggable.
We use 2
CustomScrollbarcomponents in each Explore pane, one provides horizontal scroll for when a pane is < 600px wide, the other for when content overflows vertically.Due to how they are positioned and rendered, the horizontal one was also rendering a vertical track (without showing the scrollbar) that was positioned on top of the actual vertical scrollbar, thus making it impossible to drag the latter.
By explicitly disabling the vertical track on the horizontal
CustomScrollbar, the vertical track is not rendered, which makes it possible for the actual vertical scollbar to be dragged.Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes https://github.com/grafana/support-escalations/issues/8121
Fixes #77202
Special notes for your reviewer:
Please check that: