Chore: Upgrade Go to 1.21.3 #77304
Merged
Chore: Upgrade Go to 1.21.3 #77304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
added
type/chore
no-backport
ryantxu
requested review from
nikimanoledaki,
suntala and
yangkb09
and removed request for
a team
ryantxu
commented
Oct 27, 2023
| @@ -1,6 +1,3 @@ | |||
| //go:build go1.3 | |||
| // +build go1.3 | |||
There was a problem hiding this comment.
with these tags, the build results are:
go build -ldflags -w -X main.version=10.3.0-pre -X main.commit=caa185df53 -X main.buildstamp=1698422981 -X main.buildBranch=use-golant-121 -o ./bin/grafana ./pkg/cmd/grafana
# github.com/grafana/grafana/pkg/web
pkg/web/macaron.go:48:14: predeclared any requires go1.18 or later (-lang was set to go1.21; check go.mod)
pkg/web/macaron.go:73:13: cannot use http.NotFound (value of type func(w http.ResponseWriter, r *http.Request)) as Handler value in argument to m.NotFound
pkg/web/macaron.go:107:6: type aliases requires go1.9 or later (-lang was set to go1.21; check go.mod)
pkg/web/macaron.go:122:15: invalid operation: handler (variable of type Handler) is not an interface
exit status 1
exit status 1
make[1]: *** [build-go] Error 1
ryantxu
added
add to changelog
and removed
no-changelog
grafana-pr-automation
bot
added
type/build-packaging
type/ci
kminehart
reviewed
Oct 31, 2023
ryantxu
commented
Nov 1, 2023
| @@ -635,7 +635,6 @@ embed.go @grafana/grafana-as-code | |||
| /.github/workflows/issue-opened.yml @grafana/grafana-community-support | |||
| /.github/workflows/metrics-collector.yml @torkelo | |||
| /.github/workflows/milestone.yml @marefr | |||
| /.github/workflows/ox-code-coverage.yml @grafana/explore-squad | |||
There was a problem hiding this comment.
removed since not used by explore anymore... see grafana/code-coverage#29 (comment)
There was a problem hiding this comment.
The @grafana/observability-logs was using that workflow to report coverage changes btw.
kminehart
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Update the min go version to 1.21. (see also #76359)
Why do we need this feature?
This lets us use new features added in 1.21. This lets us use the new standard library functions rather than the ones in `"golang.org/x/exp/..." (eg slices+maps)
Who is this feature for?
Developers