Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo: Fix TraceQL autocompletion with missing } #77365

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

fabrizio-grafana
Copy link
Contributor

Currently, when a } is missing and thus a spanset is incomplete, the autocompletion system doesn't properly handle attributes containing trigger characters such as .. This PR fixes this.

Fixes #77319

@fabrizio-grafana fabrizio-grafana self-assigned this Oct 30, 2023
@fabrizio-grafana fabrizio-grafana marked this pull request as ready for review October 30, 2023 12:33
@fabrizio-grafana fabrizio-grafana requested a review from a team as a code owner October 30, 2023 12:33
@fabrizio-grafana fabrizio-grafana merged commit 39014e7 into main Nov 7, 2023
23 checks passed
@fabrizio-grafana fabrizio-grafana deleted the otp/fix-traceql-editor branch November 7, 2023 10:11
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TraceQL Autocomplete exits when typing . if there is no closing }
3 participants