Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.2.x] InfluxDB: Fix parsing multiple tags on backend mode #77382

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

itsmylife
Copy link
Contributor

Backport 6b13064 from #77340


What is this feature?

This is fixing the response when we have multiple tags in the response. Multiple tags must be separated by a comma in the result. This also allows us to be in sync with the frontend mode result.

Why do we need this feature?

To have a proper output

Who is this feature for?

InfluxDB InfluxQL backend mode users

Special notes for your reviewer:

How to test?

  • Run dev environment with feature flag influxdbBackendMigration=true
  • Use this query as an example SELECT "usage_idle" FROM "cpu" WHERE $timeFilter GROUP BY "cpu"::tag, "host"::tag
  • Observe that you get the response (see it on the legend) back as cpu.usage_idle {cpu: cpu3 host: 41c9dcf3b960}
  • Switch to this branch and run the query again
  • Observe that you get the response (see it on the legend) back as cpu.usage_idle {cpu: cpu3, host: 41c9dcf3b960}

* Multiple tags separated by comma in the result

* A non-flaky unit test

(cherry picked from commit 6b13064)
@itsmylife itsmylife merged commit 1c11ba7 into v10.2.x Oct 30, 2023
12 checks passed
@itsmylife itsmylife deleted the backport-77340-to-v10.2.x branch October 30, 2023 15:35
@aangelisc aangelisc modified the milestones: 10.2.x, 10.2.1 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants