Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Respect data source version when provisioning #77428

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

andresmgot
Copy link
Contributor

What is this feature?

According to the documentation, specifying a version when provisioning a data source would be used to compare with the existing version in the database. If the version provisioned is older, the data source should not be updated. Prior to this PR, the version specified in the provisioning file was being ignored.

Which issue(s) does this PR fix?:

Fixes #75722

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

@andresmgot andresmgot enabled auto-merge (squash) November 2, 2023 10:18
@andresmgot andresmgot merged commit 82a7e12 into main Nov 2, 2023
15 checks passed
@andresmgot andresmgot deleted the provisioningUpdateVersion branch November 2, 2023 10:27
grafana-delivery-bot bot pushed a commit that referenced this pull request Nov 2, 2023
andresmgot added a commit that referenced this pull request Nov 2, 2023
)

Bug Fix: Respect data source version when provisioning (#77428)

(cherry picked from commit 82a7e12)

Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Provision: The settings of the datasources in the UI are not saved
4 participants