Explore: Fix support for angular based datasource editors #77486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elfo404
force-pushed
the
gio/fix/explore-angular-plugins
branch
from
8692c9a
to
15f8c4f
Compare
|
It looks like they are some failing tests related to Node version, but I don't know if that's related to this PR |
3 tasks
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
(cherry picked from commit 7737226)
Elfo404
added a commit
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
in #66286 we mistakenly removed the eventbridge initialization code from Explore panes, this is causing explore to error when receiving data because no eventBridge is present in the store.
This PR restores the event bridge so that angular plugins can keep functioning in Explore.
Why do we need this feature?
To make angular plugins work in Explore
Who is this feature for?
Explore uses that still use angular based editors
Which issue(s) does this PR fix?:
Fixes #77451
Special notes for your reviewer:
Please check that: