Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grafana/ui: Move the Stack component out of unstable #77495

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Grafana/ui: Move the Stack component out of unstable #77495

merged 2 commits into from
Nov 2, 2023

Conversation

Clarity-89
Copy link
Contributor

What is this feature?

Move the Stack component out of the unstable folder and make it importable from @grafana/ui directly.

Why do we need this feature?

To enable the Stack component to be used outside of the Grafana codebase.

Which issue(s) does this PR fix?:

Part of #76516.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Clarity-89 Clarity-89 added this to the 10.3.x milestone Nov 1, 2023
@Clarity-89 Clarity-89 self-assigned this Nov 1, 2023
@Clarity-89 Clarity-89 requested review from a team as code owners November 1, 2023 12:24
@Clarity-89 Clarity-89 requested review from Jguer, IevaVasiljeva, dprokop, kaydelaney, joshhunt, ashharrison90 and academo and removed request for a team November 1, 2023 12:24
JoaoSilvaGrafana
JoaoSilvaGrafana approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Clarity-89 Clarity-89 merged commit d62170e into main Nov 2, 2023
29 checks passed
@Clarity-89 Clarity-89 deleted the grafana-ui/release-stack branch November 2, 2023 10:22
zserge pushed a commit that referenced this pull request Nov 9, 2023
@Clarity-89 @zserge
Grafana/ui: Move the Stack component out of unstable (#77495)
fb94fb8 
* grafana/ui: Move Stack out of unstable

* grafana/ui: Replace imports
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoSilvaGrafana JoaoSilvaGrafana JoaoSilvaGrafana approved these changes

@Jguer Jguer Awaiting requested review from Jguer Jguer was automatically assigned from grafana/grafana-authnz-team

@IevaVasiljeva IevaVasiljeva Awaiting requested review from IevaVasiljeva IevaVasiljeva was automatically assigned from grafana/grafana-authnz-team

@dprokop dprokop Awaiting requested review from dprokop dprokop is a code owner automatically assigned from grafana/dashboards-squad

@kaydelaney kaydelaney Awaiting requested review from kaydelaney kaydelaney is a code owner automatically assigned from grafana/dashboards-squad

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90 ashharrison90 is a code owner automatically assigned from grafana/grafana-frontend-platform

@academo academo Awaiting requested review from academo academo is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees

@Clarity-89 Clarity-89

Labels
add to changelog area/frontend no-backport Skip backport of PR
Projects
None yet
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Clarity-89 @JoaoSilvaGrafana @aangelisc