Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Prepare to remove <Graph /> from @grafana/ui #77522

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Nov 1, 2023

Currently the flot based <Graph /> component is exposed in grafana/ui. It has been deprecated for 22 months, and has many other stable alternatives -- mostly <PanelRenderer .../> or even better https://grafana.com/developers/scenes/

This PR moves the two utility functions used by the graph panel into the graph panel, and gets things ready to be removed in the next version

@ryantxu ryantxu added add to changelog no-backport Skip backport of PR labels Nov 1, 2023
@ryantxu ryantxu added this to the 10.3.x milestone Nov 1, 2023
@ryantxu ryantxu requested a review from a team as a code owner November 1, 2023 19:51
@ryantxu ryantxu requested review from leeoniya and nmarrs and removed request for a team November 1, 2023 19:51
@ryantxu ryantxu changed the title Chore: Prepare to remove the <Graph /> component from grafana/ui Chore: Prepare to remove the <Graph /> from grafana/ui Nov 1, 2023
@ryantxu ryantxu changed the title Chore: Prepare to remove the <Graph /> from grafana/ui Chore: Prepare to remove <Graph /> from @grafana/ui Nov 1, 2023
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ryantxu ryantxu merged commit fb9732e into main Nov 1, 2023
32 checks passed
@ryantxu ryantxu deleted the isolate-graph-dependencies branch November 1, 2023 21:13
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants