CloudWatch Logs: Add labels to alert and expression queries #77529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
changed the title
iwysiu
commented
Nov 2, 2023
|
|
||
| // set the group key as the display name for sync queries | ||
| for i := 1; i < len(newFrame.Fields); i++ { | ||
| valueField := newFrame.Fields[i] | ||
| for j := 1; j < len(newFrame.Fields); j++ { |
There was a problem hiding this comment.
changed this to a j because I realized it's nested in a for loop using i
iwysiu
requested review from
fridgepoet and
sarahzinger
and removed request for
a team
kevinwcyu
approved these changes
Nov 2, 2023
iwysiu
added
backport v10.2.x
type/bug
and removed
no-backport
|
Hello @iwysiu!
Please, if the current pull request addresses a bug fix, label it with the |
3 tasks
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
(cherry picked from commit 64e28c0)
iwysiu
added a commit
that referenced
this pull request
Nov 2, 2023
zserge
pushed a commit
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Labels the grouped fields for sync CloudWatch Logs queries with the fields they were grouped on.
Why do we need this feature?
In order for CloudWatch Logs queries returning multiple time series to be useful in alerts, the different time series need to be labeled with their grouping information
Who is this feature for?
Users that want to use CloudWatch Logs queries with multiple time series in alerts.
Which issue(s) does this PR fix?:
Fixes #63388
Special notes for your reviewer:
Making this a bug because it should work, even if it never has.
Please check that: