Tempo: Embed flame graph in span details #77537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joey-grafana
added
area/frontend
add to changelog
area/datasource/frontend
datasource/Tempo
no-backport
joey-grafana
requested review from
joshhunt and
JoaoSilvaGrafana
and removed request for
a team
ifrost
reviewed
Nov 6, 2023
.../app/features/explore/TraceView/components/TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx
Outdated
Show resolved
Hide resolved
public/app/features/explore/TraceView/components/TraceTimelineViewer/SpanDetail/index.tsx
Outdated
Show resolved
Hide resolved
aocenas
reviewed
Nov 6, 2023
.../app/features/explore/TraceView/components/TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx
Outdated
Show resolved
Hide resolved
public/app/features/explore/TraceView/components/TraceTimelineViewer/SpanDetail/index.tsx
Outdated
Show resolved
Hide resolved
|
I think this looks good but I would like to merge this behind different feature flag than the So I think it would be better to have another feature flag so we don't have to wait with the linking itself, while we can merge this and keep iterating on this. |
aocenas
approved these changes
Nov 23, 2023
eleijonmarck
pushed a commit
that referenced
this pull request
Nov 27, 2023
* Embed flame graph * Update test * Update test * Use toggle * Update test * Add tests * Use const * Cleanup * Update profile tag * Move flame graph out of tags, remove request and other cleanup + tests * Update test * Set flame graph by profile id and simplify logic * Cleanup and redrawListView * Create/use feature toggle
This was referenced Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Embeds a flame graph in Tempo's span details (if one exists).
Why do we need this feature?
So users can visualise profiles in their span details.
Who is this feature for?
Tempo/Pyroscope users.
Special notes for your reviewer:
You can test with the Pyroscope docker-compose.
Need to enable the feature toggle
tracesEmbeddedFlameGraph.Please check that: