Transformations: Deduplicate names when using extract fields transformation.
#77569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarkilhed
added
add to changelog
area/transformations
breaking change
oscarkilhed
requested review from
mdvictor,
baldm0mma,
tskarhed,
eledobleefe and
mckn
and removed request for
a team
oscarkilhed
changed the title
extract fields transformation.extract fields transformation.
oscarkilhed
changed the title
extract fields transformation.extract fields transformation.
oscarkilhed
deleted the
oscark/extract-field-transformation-deduplicate-field-names
branch
zserge
pushed a commit
that referenced
this pull request
Nov 9, 2023
…ormation. (#77569) * dedupe field names * add test to make sure we don't break normal case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This assigns unique names to extracted fields that collide with an already existing name on the frame. This is a breaking change and as such is behind a feature toggle.
Why do we need this feature?
If there is a name collision the frame will not be valid.
Which issue(s) does this PR fix?:
Fixes #72331
Special notes for your reviewer:
Please check that:
Release notice breaking change
In panels using the
extract fieldstransformation, where one of the extracted names collides with one of the already existing fields, the extracted field will be renamed.