[v10.2.x] RBAC: Allow scoping access to root level dashboards #77608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
* correctly check permissions to list dashboards on the root * correctly display the access inherited from general folder for dashboards * Update pkg/services/sqlstore/permissions/dashboard.go Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com> * Update dashboard_filter_no_subquery.go --------- Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com> (cherry picked from commit 159bb3c)
grafana-delivery-bot
bot
requested review from
vtorosyan and
linoman
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/backend
backport
grafana-delivery-bot
bot
requested review from
papagian,
undef1nd,
yangkb09 and
IevaVasiljeva
and removed request for
a team
IevaVasiljeva
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 159bb3c from #76987
What is this feature?
Take into account dashboard listing permissions scoped to the root (
folders:uid:general) when listing dashboards.Why do we need this feature?
To allow scoping access to root level dashboards.
Who is this feature for?
Anyone
Which issue(s) does this PR fix?:
Fixes https://github.com/grafana/grafana-enterprise/issues/5920
Special notes for your reviewer:
Please check that: