Alerting: Avoid alert list view component being unmounted every time we fetch new data #77631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaAguilarPeiron
added
area/alerting
soniaAguilarPeiron
requested review from
gillesdemey,
VikaCep and
konrad147
and removed request for
a team
gillesdemey
approved these changes
Nov 3, 2023
zserge
pushed a commit
that referenced
this pull request
Nov 9, 2023
…we fetch new data (#77631) * Avoid view component being unmounted any time we fetch new data * Render loading indicator only when loading data for the first time * Remove unnecessary useRef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR avoids alert list view being unmounted and mounted every time we got new data when fetching rules.
This resolves the issue of the list flickering whenever new data is retrieved (when panel data is refreshed).
Additionally, it relocates the loading indicator below the list to eliminate any further flickering between the list and the loading indicator.
Why do we need this feature?
Panel should not twitch every time panel data is refreshed.
Who is this feature for?
All users.
Which issue(s) does this PR fix?:
Fixes #74971
Special notes for your reviewer:
Before the change:
before-alert-panel-loading.mp4
After the change:
after-alert-panel-loading.mp4
When loading data for the first time:
panelloading.mp4
Please check that: