Snapshots: Do not return internal database ids #77672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
requested review from
juanicabanas,
AgnesToulet,
undef1nd,
suntala,
yangkb09,
dprokop and
ivanortegaalba
and removed request for
a team
evictorero
reviewed
Nov 6, 2023
| @@ -29,11 +29,11 @@ type DashboardSnapshot struct { | |||
|
|
|||
| // DashboardSnapshotDTO without dashboard map | |||
| type DashboardSnapshotDTO struct { | |||
| ID int64 `json:"id" xorm:"id"` | |||
| ID int64 `json:"-" xorm:"id"` | |||
There was a problem hiding this comment.
The entire purpose of this DashboardSnapshotDTO seems to be returning the search response, we could remove those fields instead of changing the JSON name field
There was a problem hiding this comment.
Yes -- but i am reluctant to make too big of change without a concrete destination :). With this minimal change, we keep all internal logic the same but do not leak the the database ids over the public api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snapshots API currently returns three internal database ids that are not needed or used by clients:
Limiting usage of internal database ids greatly simplifies any multi-tenant migration efforts. Since they are not required here, lets just remove them. See #77667