Grafana/ui: Unify flex shorthand props #77768
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the API between the
Stack
andBox
components is inconsistent:Stack
supports aflexGrow
prop, whileBox
has agrow
prop, which is then used to set the value of theflex
shorthand property. Beyond this inconsistency, assigning only thegrow
value as the complete value offlex
sets theshrink
andbasis
implicitly. While this approach works fine in most cases, it creates some edge cases that are not immediately obvious. For instance, by settingflex: 1
on the element,flex-basis
is set to0
, and this value will overwrite anywidth
value on the component should we add those in the future (flex-basis
, unless set toauto
, has precedence overwidth
). For this reason, it is better to be explicit when setting flex values.What is this feature?
flex
prop.Why do we need this feature?
Consistent API across the layout components.
Which issue(s) does this PR fix?:
Part of ##76516
Special notes for your reviewer:
Please check that: