Tempo: Allow quotes in tag names and attributes #77864
Conversation
fabrizio-grafana
requested review from
academo
and removed request for
a team
|
@joe-elliott Tagging you just to be sure we are on the same page that allowing to use quotes for attribute names can also allow for some weird tag names and thus queries (see example in the PR description). I think this is a caveat we cannot avoid and that it is up to the user to avoid to abuse of this feature (usage of quotes in attribute names). But if you have better ideas, happy to hear them! |
|
Yup, this definitely makes some horrible things possible :). This is fine because if you are naming your tags:
Then it's ok that your TraceQL queries look unreadable. |
There was a problem hiding this comment.
Could we get a more detailed error message for this?
Also, honestly I'm not sure why we need to support some of these strange strings with quotes all over the place :D Is it because the quotes can technically be anywhere in the string and we are not sure of all the cases where it would be invalid/valid so it would be difficult to restrict where the quotes can be? (so we just basically allow the quotes in many places)
We can discuss this, also with the Tempo squad. For now I've just implemented the original request and according to what Tempo allows, namely quotes at any point: |
|
Discussed offline. We agreed to allow quotes as in Tempo, at least for the moment. |
fabrizio-grafana
requested review from
joey-grafana
and removed request for
academo
Allow tag names and values to use
". Examples:Note that this allows to write queries that might look wrong at first sight. Example (note the missing closing double quote after
GET):Also, note that for autocompletion to work properly, we need a corresponding fix in Tempo, as mentioned here.
Fixes #77394
Fixes #77685