Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: Refactor OAuth connectors' initialization #77919

Merged
merged 33 commits into from
Nov 20, 2023
Merged

Auth: Refactor OAuth connectors' initialization #77919

merged 33 commits into from
Nov 20, 2023

Conversation

mgyongyosi
Copy link
Contributor

@mgyongyosi mgyongyosi commented Nov 9, 2023 •
edited
Loading

What is this feature?

This PR introduces a new function for each OAuth connector which instantiates the specific provider by receiving the config parameters as an input of map[string]any type.

Why do we need this feature?

Required for the reloading functionality of the SSO Setting API.

Who is this feature for?

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.3.x milestone Nov 9, 2023
@mgyongyosi mgyongyosi force-pushed the mgyongyosi/refactor-azuread-init branch from 689586d to deff00d Compare November 10, 2023 15:40
@mgyongyosi mgyongyosi force-pushed the mgyongyosi/refactor-azuread-init branch from ad64509 to b60baf0 Compare November 10, 2023 15:57
@mgyongyosi mgyongyosi force-pushed the mgyongyosi/refactor-azuread-init branch from b60baf0 to 3365ba3 Compare November 10, 2023 16:13
@mgyongyosi mgyongyosi marked this pull request as ready for review November 10, 2023 16:13
@mgyongyosi mgyongyosi requested review from a team as code owners November 10, 2023 16:13
@mgyongyosi mgyongyosi requested review from papagian, undef1nd and yangkb09 and removed request for a team November 10, 2023 16:13
kalleep
kalleep reviewed Nov 13, 2023
View reviewed changes
pkg/login/social/util.go Outdated Show resolved Hide resolved
@mgyongyosi mgyongyosi force-pushed the mgyongyosi/refactor-azuread-init branch from e4ff8bd to b5dbe78 Compare November 14, 2023 11:42
@mgyongyosi mgyongyosi force-pushed the mgyongyosi/refactor-azuread-init branch from b5dbe78 to 6e18147 Compare November 14, 2023 11:55
kalleep
kalleep reviewed Nov 14, 2023
View reviewed changes
pkg/login/social/util.go Outdated Show resolved Hide resolved
kalleep
kalleep reviewed Nov 15, 2023
View reviewed changes
pkg/login/social/generic_oauth.go Show resolved Hide resolved
pkg/login/social/social.go Outdated Show resolved Hide resolved
pkg/login/socialtest/social_connector_mock.go Outdated Show resolved Hide resolved
@mgyongyosi mgyongyosi force-pushed the mgyongyosi/refactor-azuread-init branch from 7516e91 to f7ed295 Compare November 15, 2023 17:30
@mgyongyosi mgyongyosi force-pushed the mgyongyosi/refactor-azuread-init branch from f7ed295 to b2a37af Compare November 15, 2023 17:57
@mgyongyosi mgyongyosi force-pushed the mgyongyosi/refactor-azuread-init branch from e8aced6 to 057015c Compare November 16, 2023 14:57
@mgyongyosi mgyongyosi merged commit 437ae8e into main Nov 20, 2023
15 checks passed
@mgyongyosi mgyongyosi deleted the mgyongyosi/refactor-azuread-init branch November 20, 2023 08:45
@sathieu sathieu mentioned this pull request Nov 20, 2023
Closed
10 tasks
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalleep kalleep kalleep approved these changes

@Rydez Rydez Awaiting requested review from Rydez

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

@undef1nd undef1nd Awaiting requested review from undef1nd undef1nd was automatically assigned from grafana/backend-platform

@yangkb09 yangkb09 Awaiting requested review from yangkb09 yangkb09 was automatically assigned from grafana/backend-platform

@dmihai dmihai Awaiting requested review from dmihai

@linoman linoman Awaiting requested review from linoman

Assignees
No one assigned
Labels
add to changelog area/auth/oauth area/auth area/backend no-backport Skip backport of PR
Projects
None yet
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mgyongyosi @linoman @dmihai @kalleep @aangelisc