-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InfluxDB: Add new truthiness operators (Is
and Is Not
) to InfluxQL Query Builder
#77923
Conversation
@itsmylife - this should be ready for review. The latest 3 commits add type inference so that The front-end code has also been updated so that correct translation occurs when the user switches between builder and raw mode (I didn't think to check that on the previous PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good! ❤️
Could you please provide tests for influx_query_model too?
Thanks in advance!
👍 done! |
@itsmylife FYI, that pending check just shows "Build is blocked, please, contact repo admin in order to proceed" (same on the other PR too). |
@btasker I will enable it when we'll fix the problem in our CI pipeline. There is an unrelated thing broken right now. |
👍 Thanks - was just double checking I hadn't broken anything :) |
@btasker I merged the other PR and we got conflicts with this one. Could you please resolve them? I tried on github UI and failed :) And I don't want to mess your PR up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM it just needs the conflicts to resolve
👍 Sure will look at these a little later (I had a feeling we might get some) |
…L Editor for use with boolean fields
…lation between raw and builder works
…Is/Is Not Tags: always quote Integer: Don't quote Float: Don't quote Boolean: Don't quote String: Quote
5ededab
to
585a817
Compare
Github's UI was failing me too, so I've rebased on |
@btasker now there is a linting issue. But we are quite close to merge it :)
|
Got it - looks like I accidentally introduced some additional whitespace whilst rebasing (lint-prettier doesn't get called during that process because there's no commit to trigger the hooks) |
What is this feature?
Implements support for including query conditions based upon boolean field values using new Is and Is Not operators (see note below) (#77794).
Why do we need this feature?
There's a pre-existing issue where it's not possible because after submission, the value will be coerced to a string (e.g. false will be coerced to 'false').
Who is this feature for?
Users who want to use the InfluxQL Query Builder to build WHERE conditions based on Boolean fields
Which issue(s) does this PR fix?:
Fixes #77794
Special notes for your reviewer:
Please check that: