Transformations: Fix Timeseries to table transformation trend reduction when result is 0 #78026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on when result is 0 When reduceField function returns 0, the reduced value is set to null. I think we can remove this "|| null" statement, as: - There is a check a few lines above to make sure the field type is a number. This might be a reasonable guarantee that the calculation we are doing will make sense and there will be no need to set to null. - Sparkline cell type already has an option to hide value if we believe the calculation does not make sense. Fixes grafana#78025
oserde
requested review from
a team,
oscarkilhed and
baldm0mma
and removed request for
a team
grafana-pr-automation
bot
added
area/frontend
pr/external
|
|
oscarkilhed
requested changes
Nov 13, 2023
public/app/features/transformers/timeSeriesTable/timeSeriesTableTransformer.ts
Show resolved
Hide resolved
oscarkilhed
added
no-changelog
oscarkilhed
approved these changes
Nov 14, 2023
oscarkilhed
added
add to changelog
and removed
no-changelog
|
Went ahead and updated the PR with my suggested changes. |
mdvictor
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reduceField function returns 0, the reduced value is set to null. I think we can remove this "|| null" statement, as:
Fixes #78025