Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki: Fix escaping in cheatsheet #78046

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

ivanahuckova
Copy link
Member

The values in cheatsheet were not escaped properly. This PR adds escaping + test.

Before:

image image

After:

image image

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ivanahuckova ivanahuckova requested a review from a team as a code owner November 13, 2023 12:09
@ivanahuckova ivanahuckova self-assigned this Nov 13, 2023
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.3.x milestone Nov 13, 2023
@ivanahuckova ivanahuckova added type/bug datasource/Loki no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Nov 13, 2023
@ivanahuckova ivanahuckova merged commit c91fc18 into main Nov 13, 2023
29 checks passed
@ivanahuckova ivanahuckova deleted the ivana/fix-loki-cheatsheet branch November 13, 2023 14:13
@ivanahuckova ivanahuckova added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Nov 13, 2023
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants