Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Add AWS/MediaLive metric for CloudWatch #78163

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

arabian9ts
Copy link
Contributor

What is this feature?

This PR adds AWS/MediaLive metric for CloudWatch plugin.
I extracted metric names and dimensions using the commands below.

metric names
$ aws cloudwatch list-metrics --namespace AWS/MediaLive --region ap-northeast-1 | jq '.Metrics[].MetricName' | sort | uniq

dimensions
$ aws cloudwatch list-metrics --namespace AWS/MediaLive --region ap-northeast-1 | jq '.Metrics[].Dimensions[].Name' | sort | uniq

cf. https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/viewing_metrics_with_cloudwatch.html

Why do we need this feature?

I'm building grafana dashboard for the video streaming service.

Who is this feature for?

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@arabian9ts arabian9ts requested a review from a team as a code owner November 15, 2023 06:06
@arabian9ts arabian9ts requested review from idastambuk and kevinwcyu and removed request for a team November 15, 2023 06:06
@CLAassistant
Copy link

CLAassistant commented Nov 15, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@fridgepoet fridgepoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@fridgepoet fridgepoet added this to the 10.3.x milestone Nov 15, 2023
@fridgepoet fridgepoet enabled auto-merge (squash) November 15, 2023 16:33
@fridgepoet fridgepoet merged commit 210ec82 into grafana:main Nov 15, 2023
33 checks passed
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants