-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Fix broken ui components when angular is disabled #78208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jackw, thanks for fixing this issue 🥇 . I gave it a test locally, and it resolves the issue reported in these escalations (esc1 and esc 2 ).
My thoughts about this PR are aligned with yours. I think this should be an interim solution. Honestly, I don't know how many other components are relying on bootstrap js in our codebase, and without knowing that, we might be impacting more users who have Angular disabled in their configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackw - don't we want to backport this to 10.2.x?
@axelavargas - I don't know neither. Think we need to dedicate some time to learn more about this.
Hello @jackw!
Please, if the current pull request addresses a bug fix, label it with the |
Ah well spotted! I've updated the labels for backporting. 👍 |
fix(frontend): move bootstrap import to app so disabling angular doesnt break ui (cherry picked from commit 1112e90)
What is this feature?
I'm not sure if we should apply the change in this PR or wait for individual tasks to remove bootstrap usage from components. e.g #76182 I could only find this one issue so not entirely sure how widespread bootstrap usage is. 🤔
This PR moves the bootstrap import from angular app to react app to resolve issues where certain components break due to missing bootstrap js when angular is disabled. We should consider this an interim solution to buy time for auditing / removing remaining bootstrap usage across the codebase without impacting users that have angular disabled in configs.
Why do we need this feature?
So angular can be disabled without causing ui issues.
Who is this feature for?
Grafana users
Which issue(s) does this PR fix?:
Fixes #76258
Special notes for your reviewer:
Please check that: