[v10.2.x] Explore: Fix queries (cached & non) count in usage insights #78216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
* Fix: Fix queries (cached & non) count in usage insights * also keep deprecated error property * Fix & refactor tests (cherry picked from commit 42a3f36)
grafana-delivery-bot
bot
requested review from
axelavargas and
ivanortegaalba
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/frontend
backport
Elfo404
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 42a3f36 from #78097
What is this feature?
Fixes Explore query stats reporting for usage insights by reusing the
enrichWithDashboardInfofunction (renamed toenrichWithInfo).Given that
enrichWithDashboardInfois only attaching dashboard info when there's an open dashboard the code is slightly simplified, and no special-casing for explore is needed.Why do we need this feature?
Currently running queries in Explore reuslts in the total number of series reported as number of queries. data from usage-insights is therefore skewed.
Which issue(s) does this PR fix?:
Fixes #https://github.com/grafana/support-escalations/issues/7863
Special notes for your reviewer:
Please check that: