[v10.2.x] Alerting: Fix export with modifications URL when mounted on subpath #78217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
grafana-delivery-bot
bot
requested review from
gillesdemey,
VikaCep,
konrad147 and
soniaAguilarPeiron
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/alerting
gillesdemey
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3dac373 from #77622
What is this feature?
This PR fixes incorrect redirect when exporting a rule with changes. The bug initially surfaced because
history.pushwas being combined withcreateUrl–history.pushfrom the location service already prepends the subUrl.This PR uses the
urlproperty for a menu item with the result ofcreateUrl().Which issue(s) does this PR fix?:
Fixes #77149
Special notes for your reviewer: