[v10.2.2] SaveDashboardPrompt: Reduce time to open drawer when many changes applied #78308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanortegaalba
added
type/bug
area/frontend
add to changelog
backport
ivanortegaalba
requested review from
axelavargas and
dprokop
and removed request for
a team
margotphelps
changed the title
|
Updated the title to indicate release version 10.2.2 as that is what was added to the release schedule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f32f8a1 from #78283
What is this feature?
These changes improve the performance when clicking on the save toolbar button to open the drawer. Because the Auto-generate button was pre-generating messages based on changes no matter if the LLM plugin is enabled or not, the drawer was taking a long time for no reason.
Now, the button support receives the
messagesprop as a callback, so the component consumer can decide when to compose the messages, at rendering time or when clicking.Why do we need this feature?
For long dashboards, when a change is made, generating the messages gets very expensive, and this blocks the drawer for some seconds before is displayed.
Who is this feature for?
This applies to any version after 10.2.0 where the
dasghgptfeature toggle is enabled by default.Which issue(s) does this PR fix?:
Fixes #78234
Special notes for your reviewer:
Please check that: