Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthProxy: Do not allow sessions to be assigned with other methods #78602

Merged
merged 1 commit into from
Nov 24, 2023
Merged

AuthProxy: Do not allow sessions to be assigned with other methods #78602

merged 1 commit into from
Nov 24, 2023

Conversation

Jguer
Copy link
Contributor

@Jguer Jguer commented Nov 23, 2023

What is this feature?

Check user has been authenticated with auth proxy before assigning a session

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Jguer Jguer self-assigned this Nov 23, 2023
@Jguer Jguer requested review from a team as code owners November 23, 2023 15:24
@Jguer Jguer requested review from zserge, mildwonkey and nikimanoledaki and removed request for a team November 23, 2023 15:24
@Jguer Jguer added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes add to changelog and removed no-changelog Skip including change in changelog/release notes labels Nov 23, 2023
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.3.x milestone Nov 23, 2023
@Jguer Jguer changed the title Authn: Do not allow login token with other methods AuthProxy: Do not allow login token to be assigned with other methods Nov 23, 2023
@Jguer Jguer changed the title AuthProxy: Do not allow login token to be assigned with other methods AuthProxy: Do not allow sessions to be assigned with other methods Nov 24, 2023
@Jguer Jguer merged commit 7d559bc into main Nov 24, 2023
28 checks passed
@Jguer Jguer deleted the jguer/fix-auth-jwt-using-enable-login-token branch November 24, 2023 10:00
eleijonmarck pushed a commit that referenced this pull request Nov 27, 2023
@Jguer @eleijonmarck
AuthProxy: Do not allow sessions to be assigned with other methods (#…
668f433 
…78602)

do not allow login token with other methods
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyongyosi mgyongyosi mgyongyosi approved these changes

@IevaVasiljeva IevaVasiljeva IevaVasiljeva approved these changes

@kalleep kalleep kalleep approved these changes

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki nikimanoledaki was automatically assigned from grafana/backend-platform

Assignees

@Jguer Jguer

Labels
add to changelog area/backend no-backport Skip backport of PR
Projects
None yet
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Jguer @mgyongyosi @IevaVasiljeva @kalleep @aangelisc